Weapon filter not working

[Gibimbius]

try this

It works. Is there a clean way to make the unit reduce 5% to hit for each adjacent friendly unit? For instance, if there are 3 adjacent friendly units, it reduces 15% to hit in total

[gfgtdf]

I think you can you need to use a formula in sub that counts the number of adjacent friendly units, but im not sure of whihc unit it will count hte adjacent units.

[Celtic_Minstrel]

In the general case yes, but if you use special_active and that weapon special itself has a filter, then special_active will only return true for the weapon that is currently used in the combat.

This sounds like a bug… shouldn't special_active return true if the attack has a special that's active? Where "active" means that it will take effect if the weapon were to be used right now… so, for example, you should be able to use it to test whether a rogue is in a valid position for backstabbing.

In fact [has_attack] has to be used over [filter_attack] in events that handle wepopn specials, see https://github.com/wesnoth/wesnoth/issues/3317 (this is iirc because [filter_attack] is evalated on a _copy_ of the attack object that was used in combat that has the attack context not set correctly.)

Well, obviously this bug really needs fixing…

I think you can you need to use a formula in sub that counts the number of adjacent friendly units, but im not sure of whihc unit it will count hte adjacent units.

WFL uses a function to get adjacent locations, so it would use whatever unit (or location) you tell it to.

[gfgtdf]

This sounds like a bug… shouldn't special_active return true if the attack has a special that's active? Where "active" means that it will take effect if the weapon were to be used right now… so, for example, you should be able to use it to test whether a rogue is in a valid position for backstabbing.

Hmm, hard to say i guess at least for weapon specials that don't depend on the attack context that would make sense, but if we change that please only do it on 1.15 since 1.14 addons depend on the current behaviour, and not without fixing the other bug before since the dependence on this behviour is a workaround for the other bug.

Well, obviously this bug really needs fixing…

yes

[lhybrideur]

try this

It works. Is there a clean way to make the unit reduce 5% to hit for each adjacent friendly unit? For instance, if there are 3 adjacent friendly units, it reduces 15% to hit in total

Maybe you could store adjacent units (case 1) or adjacent ally units (case 2) in a variable, then do a foreach over the variable and add one for each ally (case 1) or for each unit (case 2).
But there might be a lighter solution

[newfrenchy83]

try this

It works. Is there a clean way to make the unit reduce 5% to hit for each adjacent friendly unit? For instance, if there are 3 adjacent friendly units, it reduces 15% to hit in total

Code: Select all

        [chance_to_hit]
	    id=dformation1
            name= _ ""
            description= _ "makes 5% harder to hit when next to a friend"
	    sub=5
	    apply_to=opponent
	    [filter_self]
	     [filter_adjacent]
	        is_enemy=no
                count=1-5
            [/filter_adjacent]
            [/filter_self]
        [/chance_to_hit]
        [chance_to_hit]
	    id=dformation2
	    sub=5
	    apply_to=opponent
	    [filter_self]
	     [filter_adjacent]
	        is_enemy=no
                count=2-5
            [/filter_adjacent]
            [/filter_self]
        [/chance_to_hit]
        [chance_to_hit]
	    id=dformation3
	    sub=5
	    apply_to=opponent
	    [filter_self]
	     [filter_adjacent]
	        is_enemy=no
                count=3-5
            [/filter_adjacent]
            [/filter_self]
        [/chance_to_hit]
        [chance_to_hit]
	    id=dformation4
	    sub=5
	    apply_to=opponent
	    [filter_self]
	     [filter_adjacent]
	        is_enemy=no
                count=4-5
            [/filter_adjacent]
            [/filter_self]
        [/chance_to_hit]
        [chance_to_hit]
	    id=dformation5
	    sub=5
	    apply_to=opponent
	    [filter_self]
	     [filter_adjacent]
	        is_enemy=no
                count=5
            [/filter_adjacent]
            [/filter_self]
        [/chance_to_hit]

this is similar to UTBS ability 'formation in wesnoth 1.15.2/3