"no gold + no move" bug

[SlowThinker]

I guess everybody knows the bug when a player disconnects and his side loses his gold and movement.
Firstly two ways how to manage this problem:

Solution 1:

repairing reloaded games corrupted replays HOWTO:
1. save the game
2. open another Wesnoth client and load saved game as a replay (check the "Show replay" checkbox at the bottom of the Load Game dialog box)
3. check the "Skip animation" check box at the top of the screen
4. run the replay by clicking on "continuous replay"
5. when you reach the turn of the side before the disconnected guy, click on "pause at the end of turn"
6. save the game and reload.

Solution 2:

This is my way how to solve this problem:

• Remember correct gold of all players
• Let all players end their turns, so that movement is returned.
• Then save, and edit snapshot.side.gold to correct values

an example what shall be edited

Code: Select all

[side]
	action_bonus_count="36"
	allow_player="yes"
	colour="1"
	controller="human"
	countdown_time="0"
	current_player="SlowThinker"
	disallow_observers="no"
	flag=""
	flag_icon=""
	fog="yes"
	gold="2" ## edit this line   <----------------------
	gold_add="no"
	hidden="no"
	id=""
	income="24"
	name="SlowThinker"
	no_leader="yes"
	objectives=
	...
[/side]

You can simply search for this string:
countdown_time=

a note for Conquest Minus players:

if you want to ressurect the gold for a Conquest Minus save then you must edit one more line:

1. find [snapshot]
2. find assassin_multiplier=6 ; (it will be several lines below [variables]
3. then find side_gold= and edit it:

Code: Select all

max_players=8
players_ingame=8
players_living=8
players_present=8
recruitable_terrain="Hh^Vhh,Hh^Vc,Ss^Vm,Gg^Vh,Gs^Vht,Rp^Vhc,Ww^Vm,Gg^Ve,Gg^Vc,Ss^Vhs,Mm^Vhh,Uu^Vu,Rr^Vd,Dd^Vdt,Dd^Vda"
reloaded_game=yes
restore_cost=3
side_gold=2  ## edit this line  <----------------------
side_number=8
sides_with_autolabels=",2,3,6,7,1,4,5,8"
terrain_next_shipyard="Wo,Ww,Wwf"

)

Of course this way is not perfect, as one turn passes and units heal.

--------------------------------------------------------------
Now the question:
Do you know how to edit the save directly (without ending turns of all players lioke in Solution 2), and to return the moves to the side?

[StandYourGround]

Of course, the more elegant solution would be to fix the bug in Wesnoth and submit a patch...

[SlowThinker]

This is a very old bug, so I don't expect any fix.
(but I don't have 1.9, maybe it is corrected there?)

[Dunno]

Btw, I'm wondering, when does the bug occur? Is it on random basis? Because I remember times when player got disconnected but everything was alright.

[SlowThinker]

I guess the chance the bug happens is 10%.

It usually happens if the side that disconnected played its turn.

[Lich_Lord]

My understanding is that the bug occurs if the player disconnects right before their turn begins, right before they get their gold and MP.

I've seen people who've gotten the bug but still had full movement on some units because they didn't move the previous turn.

[SlowThinker]

My understanding is that the bug occurs if the player disconnects right before their turn begins, right before they get their gold and MP.

I've seen people who've gotten the bug but still had full movement on some units because they didn't move the previous turn.

I guess the bug arises this way:
It happens during the initialisation phase of the side's turn: The disconnection causes only part of the initialization information is sent from the client to the server. Wesnoth doesn't check whether the initialization is complete and applies the incomplete information.

[Anonymissimus]

And note that this very same bug
IS FIXED IN 1.10-rc1/1.9.14. Thumbs up for Soliton.
One more reason to leave 1.8 aside *now*.

[Dunno]

wooooooooo

[SlowThinker]

I don't usually spam but ...

thumbs up!

[SlowThinker]

the bug is still present in 1.10
(no idea about 1.11)

I think no player needs to disconnect in order to reproduce the bug:
if a player saves when another player is ready to start his turn and faces a window "it is now xxx's turn", then the other player gets no move and no gold in the reloaded game.

[Anonymissimus]

the bug is still present in 1.10
(no idea about 1.11)

I think no player needs to disconnect in order to reproduce the bug:
if a player saves when another player is ready to start his turn and faces a window "it is now xxx's turn", then the other player gets no move and no gold in the reloaded game.

This appears to be a different bug with similar symptoms, and should not have been posted in this thread, as the way to reproduce is clearly different (and straight forward, fortunately).
Anyway post that at gna please.

[SlowThinker]

bug when paused

if a player saves when another player is ready to start his turn and faces a window "it is now xxx's turn", then the other player gets no move and no gold in the reloaded game.

It is not correct. I did run a test and only a player that have paused the game is affected:

gna: saving+reloading may cause a side's turn is not initialized

[SlowThinker]

bug when disconnected

This appears to be a different bug with similar symptoms, and should not have been posted in this thread, as the way to reproduce is clearly different (and straight forward, fortunately).
Anyway post that at gna please.

The original bug (the one that is caused by a disconnection and not by a pause) seems to be present too in Wesnoth 1.10.7:

I played with meledestus who disconnected just before the end of my turn (he said he didn't have any dialog open). I ended my turn and got the warning that he disconnected, and saved in the beginning of his turn. After I reloaded he had no gold, although he lost no movement.
The save:

Conquest-_meledestus_side8_lost_gold_but_no_move.gz

(333.05 KiB) Downloaded 218 times