Hit and Run multiplying itself on lvl-up

[Eagle_11]

So i just noticed this bug, obviously i missed something vital.
Bug: If unit with the ability gets killing blow to level up on offense, then the amount of moves given by the ability is multiplied by itself for all units on same side with the ability. This unwanted multiplication occurs everytime unit lvls up.
Example: Unit has the ability, gains 2 moves back, after leveling up to its next lvl, its 4 for all units with the ability. Upon L3 gains all 6 moves back and i have overpowered Thief/Rogue/Assassins darting overall the place, now that was unintended.

Related ability:

Code: Select all

#define ABILITY_HITANDRUN
    
[dummy]
        
id=MRhitandrun        
name= _ "hit and run"
        
description= _ "hit and run:
 This unit gains 2 moves back after attacking an enemy."
    
[/dummy]

[/abilities]

[event]
    
name=attack_end
    
first_time_only=no
    
[store_unit]

[filter]
        
side=$side_number
ability=MRhitandrun    
x,y=$x1,$y1
[/filter]

            
variable=lerunner        
    
[/store_unit]
    
    
{VARIABLE_OP lerunner.moves add 2}

    
[unstore_unit]
        
variable=lerunner
        
{COLOR_HARM}
        
text= _ "FLEE!"
        
find_vacant=no
    
[/unstore_unit]

[/event]

[+abilities]

#enddef

[Alarantalara]

See how the feeding ability does it in core.
You'll notice that the event has an id to prevent duplication.

[Eagle_11]

I have this ability that is supposed to help economy a bit on a cannonfodder unit of an side in my mod. However its severely impacting the game balance, thus i want to add following to it: Needs to remain stationary, not having spent any movement points to produce the gold. And checks what terrain its standing on, if its a village, keep, castle, swamp or water tile doesnt produce the gold.
related:

Code: Select all

#define ABILITY_EXTRACT_LVL1
     
[leadership]
          
value=0
          
id=MRextract1
          
cumulative=no
          
name="extract"
          
description= _ "Digger: Extracting minerals from the ground under it's current position, this unit is able to help maintain the economy to some extent. It produces it's level in gold per turn, or one gold if level 0."
    
[/leadership]


[/abilities]

[event]
	
id=MRextractors
name=turn refresh
	
first_time_only=no

	
[if]
	  
[have_unit]
	   
side=$side_number
	    
ability=extract1
	  
[/have_unit]
	
[/if]

	
[store_unit]
		
[filter]
                    
side=$side_number 
	            
ability=extract1
		
[/filter]

		
variable=extractors1
		
kill=no
	
[/store_unit]

		
{FOREACH extractors1 i}
	
			 
[gold]
                            
side=$side_number 
                            
amount=1
                         
[/gold] 

			
#[scroll_to_unit]
				
#find_in=extractors1[$i]
				
#check_fogged=true
			
#[/scroll_to_unit]
			
[unstore_unit]
				
variable=extractors1[$i]
				
text="1"
			       
red,green,blue=255,255,0 
			
[/unstore_unit]
			
[delay]
			    
time=100
			
[/delay]
				
		
{NEXT i}
	
	
{CLEAR_VARIABLE extractors1}

 
[/event]

[+abilities]

#enddef

I have couple of broken weapon specs. This one is supposed to let the unit deal 50% more dmg on targets that are of a certain race. However its functioning against targets of every race, it needs to be told to filter the opponent, if equals undead then multiply dmg, else deal original dmg. (prolly inside an [event], i guess)
related:

Code: Select all

#define WEAPON_SPECIAL_LICHBANE
    
[damage]
        
id=MRlichbane        
name= _ "lichbane"
        
description= _ "Lichbane:
 This attack cuts at the tie between the undead and its corrupted source of animation, dealing additional damage to the unholy target."
        
multiply=1.5

        

[filter_opponent]
		
race=undead       
[/filter_opponent]
[/damage]

#enddef

This one is supposed to be a completory side-spec found on attacks with berserk. It's supposed to let the unit deal double dmg near death, after its hp is >11
Same problem as one above, works always. It needs to be told to filter self, if unit hitpoints equal less than 11 then multiply dmg with 2x, else deal normal dmg.

related:

Code: Select all

#define WEAPON_SPECIAL_LASTSTAND

[damage]
    
id=MRlaststand
    
name= _ "last stand"
    
description= _ "Last Stand: 
This attack will hit harder when unit's health is extremely low. 

When the unit has only 10 hitpoints or less, this attack deals double damage."
    
multiply=2
apply_to=self
[filter]

[status]
[filter_self]
	                
                                                
hitpoints="1, 2, 3, 4, 5, 6, 7, 8, 9, 10"

[/filter_self]
[/status]
[/filter]

[/damage]
#enddef

[Dugi]

For economy units, write the event like something like this (untested, petty errors might be present):

Code: Select all

[event]
 id=MRextractors
 name=turn end
 first_time_only=no
 [store_unit]
  [filter]
   side=$side_number
   ability=extract
  [/filter]
  variable=extractors
  kill=no
 [/store_unit]
 {FOREACH extractors i}
  [if]
   [variable]
    name=extractors[$i].moves
    equals=$extractors[$i].max_moves
   [/variable]
   [then]
    [gold]
     side=$side_number
     amount=$($extractors[$i].level+1)
    [/gold]
   [/then]
  [/if]
 {NEXT i}
 {CLEAR_VARIABLE extractors}

Lichbane is analogical to misanthropia from Legend of the Invincibles:

Spoiler:

Code: Select all

#define WEAPON_SPECIAL_MISANTHROPIA
   [damage]
	id=misanthropia
	name= _ "misanthropia"
#ifver WESNOTH_VERSION >= 1.11.2
        description= _ "This attack does double damage to humans."
#else
        description= _ "Misanthropia:
This attack does double damage to humans."
#endif
	multiply=2
        [filter_opponent]
		race=human
        [/filter_opponent]
   [/damage]
#enddef

Last stand has wrongly written filters (FIXME: how do I properly use the formula in filter? the information on the wiki isn't sufficient):

Code: Select all

#define WEAPON_SPECIAL_LASTSTAND
[damage]
 id=MRlaststand
 name= _ "last stand"
 description= _ "Last Stand: 
This attack will hit harder when unit's health is extremely low. 

When the unit has only 10 hitpoints or less, this attack deals double damage."
 multiply=2
 apply_to=self
 [filter_self]                                  
  formula="hitpoints<11"  #Not sure about this line, can somebody correct me if I am wrong?
 [/filter_self]
[/damage]
#enddef

[Eagle_11]

On the economy one:
Didnt function, it seems to give the gold needs set to turn refresh but then cant check the remaining moves, since turn end is needed for that. Now fearing that i wanted to do something impossible without knowing ?
Thanks for the Misanthrophia one, Lichbane and Manslayer specs are fixed now.
EDIT: Just checked the formular one, and its working too

[Dugi]

Didnt function, it seems to give the gold needs set to turn refresh but then cant check the remaining moves, since turn end is needed for that. Now fearing that i wanted to do something impossible without knowing ?

Indeed that it's impossible to do that, that's why it's a turn end event in my code and not a turn refresh event. If it doesn't work at turn end either, I think that there is just a small error, that might be quite easy to locate.

[Eagle_11]

The idea is to group {TRAIT_STRONG} with _WEAK}, _QUICK} with _SLOW}, INTELLIGENT} with _DIM}. I need to tell the game to pick one of the pairs so there aint a unit with strong and weak(and so on). Probably should define pairs, then point the trait set to those pairs but how i do the "dont pick 2 of same group" part. Another slightly related question: Is there any method to make some traits rarely chosen in a pool of atleast a dozen.

Next issue is something ive found in a certain BSH era, an non-serious one with an kittens faction. Anyways there is this magnificent piece, that allows an ranged attack to be fired over multiple hex distance using a right-click menu option. Range is defined at unit, inside weapon's [specials] clause via {ARTILLERY FIRE RANGE}, splash is only present at highest lvl advance of unit using an {SPLASH_DAMAGE VALUE TYPE} used inside [specials] again.

Also i noticed there is a typo, notice the SHPLASH. Naturally it doesnt work when ported over because of that, however it works like that at the source, how come ? The farthest i could get is to get the game able to read it via removing all splash related stuff outside, but the menu item never appeared.
I thought it would be fitting for Troll Rock- and Boulder-lobber, given their superior height.

The range definer:

Code: Select all

#define ARTILLERY_FIRE RANGE
[artillery]
  id=artillery_fire
  name=_"artillery fire {RANGE}"
  description=_"this weapon always hits..something..It can be fired at targets {RANGE} hexes away, but may deviate to one of the neighbouring hexes instead of the primary target..better not to aim it anywhere near your own units"
  value={RANGE}
[/artillery]
#enddef

The splash damage:

Code: Select all

#define SPLASH_DAMAGE DAM TYPE
[splashing]
  id=splash_damage
  name=_"splashing"
  value={DAM}
  type={TYPE}
  description=_"The explosion from where this weapon hits may deal some damage also to neighbouring units (in this weapons case - {DAM} {TYPE} damage) unless they manage to protect against the shockwave.
  (depends on unit defence on its terrain)
That means - while it's a good idea not to aim normal artillery anywhere near your own units, then those with splash damage should not be aimed anywhere near the anywhere near as well."
[/splashing]
#enddef

artillery-events:

Spoiler:

Code: Select all

# IT WORKS!!!! but still needs optimising, and so far artillery can't see to hurt itself even if it hits
# ok one bug - if artillery hits itself (funny) it unstores and doesnt pass data to ceasefire
#define CLEAR_TARGETTING
[store_locations]
  [filter]
    x,y=$shooter.x,$shooter.y
  [/filter]
  radius=$shooter.attack[1].specials.artillery.value
  variable=target_area
[/store_locations]
{FOREACH target_area i}
# must find some way to only remove the targetting image, not all of them
[remove_item]
  image=attacks/targethex.png
  x,y=$target_area[$i].x,$target_area[$i].y
[/remove_item]
{NEXT i}
#will have to do that separately if we want to clear those ugly red hexes before showing animations
#{CLEAR_VARIABLE shooter}
{CLEAR_VARIABLE target_area}
#enddef

#define SPLASH_DAMAGE_AROUND X Y DAMAGE TYPE SHOOTER
[store_unit]
  [filter]
  [filter_location]
  [filter_adjacent_location]
    x,y={X},{Y}
  [/filter_adjacent_location]
  [/filter_location]
  [/filter]
  variable=splash_victim
[/store_unit]
{FOREACH splash_victim i}
    # check for defence or harm
    {VARIABLE cth 0}
    [set_variable]
      name=random
      rand=1..100
    [/set_variable]
    {GET_DEFENCE $splash_victim[$i].x $splash_victim[$i].y cth}
    [if]
      [variable]
        name=random
        less_than_equal_to=$cth
      [/variable]
      [then]
    {HARM $splash_victim[$i].x $splash_victim[$i].y {DAMAGE} {TYPE} {SHOOTER}}
      [/then]
      [else]
        [animate_unit]
          [filter]
            x,y=$splash_victim[$i].x,$splash_victim[$i].y
          [/filter]
          flag=defend
          hits=no
          text="avoided"
          blue=255
          red=0
          green=0
        [/animate_unit]
      [/else]
    [/if]
{NEXT i}
{CLEAR_VARIABLE cth}
#enddef
[event]
name=start
# show a bombard option on a unit with the artillery fire trait
[set_menu_item]
  id=artillery_aim
  description=_"Aim artillery"
  image=attacks/cannon-icon.png
  [show_if]
    [have_unit]
      x,y=$x1,$y1
      side=$side_number
     [not]
     [filter_wml]
        attacks_left=0
     [/filter_wml]
     [/not]
      [filter_wml]
        [attack]
          [specials]
            [artillery]
            [/artillery]
          [/specials]
        [/attack]
      [/filter_wml]
    [/have_unit]
  [/show_if]
  [command]
  #anti-idiot initial cleanup
  {CLEAR_TARGETTING}
  {CLEAR_VARIABLE shooter}
  # remember who is shooting
    [store_unit]
      [filter]
        x,y=$x1,$y1
      [/filter]
      variable=shooter
    [/store_unit]
    # mark and remember the area he can shoot at
    [store_locations]
      [filter]
      x,y=$shooter.x,$shooter.y
      [/filter]
      # take range from the special, very clumsy coding
      # need something that won't require the attack to be the second one on the list
      radius=$shooter.attack[1].specials.artillery.value
      variable=target_area
    [/store_locations]
    # place targeting image on all hexes in range
    {FOREACH target_area i}
    [item]
    image=attacks/targethex.png
    x,y=$target_area[$i].x,$target_area[$i].y
    [/item]
    {NEXT i}
    {CLEAR_VARIABLE target_area}
  [/command]
[/set_menu_item]

# when we have a target area click to target
[set_menu_item]
  id=artillery_fire
  description=_"Fire artillery here"
  image=attacks/target-icon.png
  [filter_location]
      [filter]
      x,y=$shooter.x,$shooter.y
      [/filter]
      # take range from the special, very clumsy coding
      # need something that won't require the attack to be the second one on the list
      radius=$shooter.attack[1].specials.artillery.value
  [/filter_location]
  [command]
  # randomise - on 1-40 hit on 41-50 hit y+1 51-60 x+1 61-70 x+1 y-1
  # 71-80 y-1 81-90 x-1 y-1 91-100 x-1, store that loc
  # !!!!!!!!!!!!needs optimising!!!!!!!!!!! consider using switch
  #and clear up those ugly red hexes before resolving hits
  {CLEAR_TARGETTING}
  [set_variable]
    name=random
    rand=1..100
  [/set_variable]
  # bullseye 40%
  [if]
    [variable]
      name=random
      less_than_equal_to=40
    [/variable]
    [then]
      [store_locations]
        x,y=$x1,$y1
        variable=hit_target
      [/store_locations]
    [/then]
  [/if]
  # not bullseye 10% 40-50 north
  [if]
    [variable]
      name=random
      less_than_equal_to=50
    [/variable]
    [and]
    [variable]
      name=random
      greater_than=40
    [/variable]
    [/and]
    [then]
      [store_locations]
        [filter_adjacent_location]
          x,y=$x1,$y1
          adjacent=n
        [/filter_adjacent_location]
        variable=hit_target
      [/store_locations]
    [/then]
  [/if]
  # not bullseye 10% 50-60 north-east
  [if]
    [variable]
      name=random
      less_than_equal_to=60
    [/variable]
    [and]
    [variable]
      name=random
      greater_than=50
    [/variable]
    [/and]
    [then]
      [store_locations]
        [filter_adjacent_location]
          x,y=$x1,$y1
          adjacent=ne
        [/filter_adjacent_location]
        variable=hit_target
      [/store_locations]
    [/then]
  [/if]
  # not bullseye 10% 60-70 south-east
  [if]
    [variable]
      name=random
      less_than_equal_to=70
    [/variable]
    [and]
    [variable]
      name=random
      greater_than=60
    [/variable]
    [/and]
    [then]
      [store_locations]
        [filter_adjacent_location]
          x,y=$x1,$y1
          adjacent=se
        [/filter_adjacent_location]
        variable=hit_target
      [/store_locations]
    [/then]
  [/if]
  # not bullseye 10% 70-80 south
  [if]
    [variable]
      name=random
      less_than_equal_to=80
    [/variable]
    [and]
    [variable]
      name=random
      greater_than=70
    [/variable]
    [/and]
    [then]
      [store_locations]
        [filter_adjacent_location]
          x,y=$x1,$y1
          adjacent=s
        [/filter_adjacent_location]
        variable=hit_target
      [/store_locations]
    [/then]
  [/if]
  # not bullseye 10% 80-90 south-west
  [if]
    [variable]
      name=random
      less_than_equal_to=90
    [/variable]
    [and]
    [variable]
      name=random
      greater_than=80
    [/variable]
    [/and]
    [then]
      [store_locations]
        [filter_adjacent_location]
        x,y=$x1,$y1
          adjacent=sw
        [/filter_adjacent_location]
        variable=hit_target
      [/store_locations]
    [/then]
  [/if]
# not bullseye 10% 90-100 north-west
  [if]
    [variable]
      name=random
      less_than_equal_to=100
    [/variable]
    [and]
    [variable]
      name=random
      greater_than=90
    [/variable]
    [/and]
    [then]
      [store_locations]
        [filter_adjacent_location]
        x,y=$x1,$y1
          adjacent=sw
        [/filter_adjacent_location]
        variable=hit_target
      [/store_locations]
    [/then]
  [/if]
  # if there's a unit on that loc hurt it, kill if needed and give xp to shooter
  # mabee..make a hurting macro instead for simplifying?
  #resolve splashing first before hitting the primary target
  [if]
    [have_unit]
      x,y=$shooter.x,$shooter.y
      [filter_wml]
        [attack]
          [specials]
            [splashing]
            [/splashing]
          [/specials]
        [/attack]
      [/filter_wml]
    [/have_unit]
      [then]
        {BIG_EXPLOSION $hit_target.x $hit_target.y}
        {SPLASH_DAMAGE_AROUND $hit_target.x $hit_target.y $shooter.attack[1].specials.splashing.value $shooter.attack[1].specials.splashing.type shooter}
      [/then]
      [else]
        {SMALL_EXPLOSION $hit_target.x $hit_target.y}
      [/else]
  [/if]
  [if]
    [have_unit]
      x,y=$hit_target.x,$hit_target.y
    [/have_unit]
    [then]
      {HARM $hit_target.x $hit_target.y $shooter.attack[1].damage $shooter.attack[1].type shooter}
    [/then]
    #should we give xp for a total miss?
    # somewhere around here should handle splash damage, probably after /if
    # [if] [filter_attack] special=splash_damage[/filter_attack] [then]{SHPLASH_DAMAGE_OVER $hit_target.x $hit_target.y 25% $shooter.damage}
  [/if]
  #clear the shooting
# using clear_targetting macro and setting unit as having attacked instead..actually ill throw out clearing variables from the macro and use it earlier, so ust have to clean up variables here
#clear the shooters moves and attacks..but only if he's alive
[if]
  [variable]
    name=shooter.hitpoints
    greater_than=0
  [/variable]
  [then]
  {VARIABLE shooter.attacks_left 0}
  {VARIABLE shooter.moves 0}
  [unstore_unit]
    variable=shooter
  [/unstore_unit]
  [/then]
[/if]
{CLEAR_VARIABLE shooter}
{CLEAR_VARIABLE hit_target}
  [/command]
[/set_menu_item]
[/event]

#if something funny happens need to cancel targeting
[event]
name=select,side turn end
first_time_only=no
{CLEAR_TARGETTING}
{CLEAR_VARIABLE shooter}
[/event]

#this is going to be funny - you didn't think aiming that cannon as a normal attack would be safe did you?
[event]
name=attacker hits
  [filter_attack]
  special=splash_damage
          [specials]
            [splashing]
            [/splashing]
          [/specials]
  [/filter_attack]
{BIG_EXPLOSION $second_unit.x $second_unit.y}
{SPLASH_DAMAGE_AROUND $second_unit.x $second_unit.y $unit.attack[1].specials.splashing.value $unit.attack[1].specials.splashing.type unit}
[/event]
[event]
name=defender hits
  [filter_second_attack]
  special=splash_damage
          [specials]
            [splashing]
            [/splashing]
          [/specials]
  [/filter_second_attack]
{BIG_EXPLOSION $unit.x $unit.y}
{SPLASH_DAMAGE_AROUND $unit.x $unit.y $second_unit.attack[1].specials.splashing.value $second_unit.attack[1].specials.splashing.type second_unit}
[/event]

In Era of Chaos, there is this ability that allows a Vampire to transform into a bat(again via an rightclick menu option) and back. In my mod wanted to give this to the Malborn unit, since its a lvl1 "assassin" that cant do [censored], to actually make that unit worth a damn.
The bat is a copy of original, which has a unit_variation for each type that is supposed to have the ability. Problem is that the menu item didnt appear(again)
the unit:

Spoiler:

Code: Select all

#textdomain wesnoth-mental-rework
[unit_type]
    
id=True Vampire Bat    
name= _ "Vampire Bat"
    
race=undead    
gender=male,female
    
image="units/undead/bat-se-3.png"
    
profile="portraits/monsters/bat.png"
    
{MAGENTA_IS_THE_TEAM_COLOR}

ellipse="misc/ellipse-nozoc"

hitpoints=16
    
movement_type=smallfly
    
movement=7
    
experience=37    
level=1
    
alignment=chaotic
    
advances_to=null    
{AMLA_DEFAULTII}
cost=14
    
usage=fighter    
description= _ "Vampire bats are flying beasts that feed on the blood of other creatures. While their fangs are not very powerful, the health of victims is drained away along with their blood, and given to the Bats."+{SPECIAL_NOTES}+{SPECIAL_NOTES_DRAIN}
    
die_sound=bat-flapping.wav
    
[portrait]
        
size=400
        
side="left"
        
mirror="false"
        
image="portraits/monsters/transparent/bat.png"
    
[/portrait]
    
[portrait]
        
size=400
        
side="right"
        
mirror="true"
        
image="portraits/monsters/transparent/bat.png"
    
[/portrait]

    
[resistance]
        
pierce=110
        
fire=120
        
arcane=120
        
impact=100
    
[/resistance]
    
[defense]
        
village=60
    
[/defense]

    
[defend]
        
direction=s,sw,se
        
[if]
            
hits=miss
            
offset=0.0~-0.15,-0.15~0.0
        
[/if]
        
start_time=-126
        
[frame]
            
duration=1
            
image="units/undead/bat-se-3.png"
        
[/frame]
        
[frame]
            
duration=100
            
image="units/undead/bat-se-4.png"
        
[/frame]
        
[if]
            
hits=hit
            
[frame]
                
duration=150
                
image="units/undead/bat-se-4.png"
                
sound={SOUND_LIST:BAT_HIT}
            
[/frame]
        
[/if]
        
[else]
            
hits=miss,kill
            
[frame]
                
duration=150
                
image="units/undead/bat-se-4.png"
            
[/frame]
        
[/else]
        
[frame]
            
duration=1
            
image="units/undead/bat-se-3.png"
        
[/frame]
    
[/defend]
    
[defend]
        
direction=n,nw,ne
        
[if]
            
hits=miss
            
offset=0.0~-0.15,-0.15~0.0
        
[/if]
        
start_time=-126
        
[frame]
            
duration=1
            
image="units/undead/bat-ne-3.png"
        
[/frame]
        
[frame]
            
duration=100
            
image="units/undead/bat-ne-4.png"
        
[/frame]
        
[if]
            
hits=hit
            
[frame]
                
duration=150
                
image="units/undead/bat-ne-4.png"
                
sound={SOUND_LIST:BAT_HIT}
            
[/frame]
        
[/if]
        
[else]
            
hits=miss,kill
            
[frame]
                
duration=150
                
image="units/undead/bat-ne-4.png"
            
[/frame]
        
[/else]
        
[frame]
            
duration=1
            
image="units/undead/bat-ne-3.png"
        
[/frame]
    
[/defend]

    
[standing_anim]
        
direction=s,se,sw
        
start_time=0
        
layer=60
        
[frame]
            
duration=50
            
image="units/undead/bat-se-3.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-se-2.png"
        
[/frame]
        
[frame]
            
duration=80
            
image="units/undead/bat-se-1.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-se-2.png"
        
[/frame]
        
[frame]
            
duration=50
            
image="units/undead/bat-se-3.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-se-4.png"
        
[/frame]
        
[frame]
            
duration=80
            
image="units/undead/bat-se-5.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-se-4.png"
        
[/frame]
    
[/standing_anim]
    
[standing_anim]
        
layer=60
        
direction=n,ne,nw
        
start_time=0
        
[frame]
            
duration=50
            
image="units/undead/bat-ne-3.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-ne-2.png"
        
[/frame]
        
[frame]
            
duration=80
            
image="units/undead/bat-ne-1.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-ne-2.png"
        
[/frame]
        
[frame]
            
duration=50
            
image="units/undead/bat-ne-3.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-ne-4.png"
        
[/frame]
        
[frame]
            
duration=80
            
image="units/undead/bat-ne-5.png"
        
[/frame]
        
[frame]
            
duration=60
            
image="units/undead/bat-ne-4.png"
        
[/frame]
    
[/standing_anim]

    
[attack]
        
name=fangs
        
description=_"fangs"
        
icon=attacks/fangs-animal.png
        
type=pierce
        
range=melee
        
damage=5
        
number=2
        
[specials]
            
{WEAPON_SPECIAL_DRAIN}
            
{WEAPON_SPECIAL_BACKSTAB}
        
[/specials]
    
[/attack]
    
[attack_anim]
        
[filter_attack]
            
name=fangs
        
[/filter_attack]
        
direction=s,se,sw
        
offset=0.0~0.9:200,0.9~0.0:160
        
start_time=-200
        
[frame]
            
duration=30
            
image="units/undead/bat-se-3.png"
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-se-2.png"
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-se-1.png"
            
sound=bat-flapping.wav
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-se-2.png"
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-se-3.png"
        
[/frame]
        
[if]
            
hits=yes
            
[frame]
                
duration=70
                
image="units/undead/bat-se-4.png"
                
sound=bite-small.ogg
            
[/frame]
        
[/if]
        
[else]
            
hits=no
            
[frame]
                
duration=70
                
image="units/undead/bat-se-4.png"
                
sound={SOUND_LIST:MISS}
            
[/frame]
        
[/else]
        
[frame]
            
duration=50
            
image="units/undead/bat-se-3.png"
        
[/frame]
        
[frame]
            
duration=50
            
image="units/undead/bat-se-2.png"
        
[/frame]
        
[frame]
            
duration=40
            
image="units/undead/bat-se-3.png"
        
[/frame]
    
[/attack_anim]

    
[attack_anim]
        
[filter_attack]
            
name=fangs
        
[/filter_attack]
        
direction=n,ne,nw
        
offset=0.0~0.9:200,0.9~0.0:160
        
start_time=-200
        
[frame]
            
duration=30
            
image="units/undead/bat-ne-3.png"
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-ne-2.png"
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-ne-1.png"
            
sound=bat-flapping.wav
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-ne-2.png"
        
[/frame]
        
[frame]
            
duration=30
            
image="units/undead/bat-ne-3.png"
        
[/frame]
        
[if]
            
hits=yes
            
[frame]
                
duration=70
                
image="units/undead/bat-ne-4.png"
                
sound=bite-small.ogg
            
[/frame]
        
[/if]
        
[else]
            
hits=no
            
[frame]
                
duration=70
                
image="units/undead/bat-ne-4.png"
                
sound={SOUND_LIST:MISS}
            
[/frame]
       
[/else]
        
[frame]
            
duration=50
            
image="units/undead/bat-ne-3.png"
        
[/frame]
        
[frame]
            
duration=50
            
image="units/undead/bat-ne-2.png"
        
[/frame]
        
[frame]
            
duration=40
            
image="units/undead/bat-ne-3.png"
        
[/frame]
    
[/attack_anim]

    
[extra_anim]
        
flag=transform
        
start_time=0
        
{BAT_TRANSFORM_FRAME "bat-se-1" "128,0,0" 0 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-2" "128,0,0" 0.05 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-3" "128,0,0" 0.1 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-4" "128,0,0" 0.25 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-5" "128,0,0" 0.35 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-4" "128,0,0" 0.4 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-3" "128,0,0" 0.45 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-2" "128,0,0" 0.5 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-1" "128,0,0" 0.55 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-2" "128,0,0" 0.6 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-3" "128,0,0" 0.65 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-4" "128,0,0" 0.7 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-5" "128,0,0" 0.75 ()}
        
{BAT_TRANSFORM_FRAME "bat-se-4" "128,0,0" 0.75 (alpha=1~0.75)}
        
{BAT_TRANSFORM_FRAME "bat-se-3" "128,0,0" 0.5 (alpha=0.75~0.50)}
        
{BAT_TRANSFORM_FRAME "bat-se-2" "128,0,0" 0.5 (alpha=0.50~0.25)}
        
{BAT_TRANSFORM_FRAME "bat-se-1" "128,0,0" 0.25 (alpha=0.25~0)}
    
[/extra_anim]

    
[extra_anim]
        
flag=trans_finish
        
start_time=0
        
{BAT_TRANSFORM_FRAME "bat-se-1" "128,0,0" 0.25 (alpha=0~0.25)}
        
{BAT_TRANSFORM_FRAME "bat-se-2" "128,0,0" 0.5 (alpha=0.25~0.50)}
        
{BAT_TRANSFORM_FRAME "bat-se-3" "128,0,0" 0.75 (alpha=0.50~0.75)}
        
{BAT_TRANSFORM_FRAME "bat-se-4" "128,0,0" 0.75 (alpha=0.75~1)}
        
{BAT_TRANSFORM_FRAME "bat-se-5" "128,0,0" 0.75 ()}
    
[/extra_anim]

[/unit_type]

variation ding:

Code: Select all

#textdomain wesnoth-mental-rework
[unit_type]
    
id=Malborn Bat
    
name= _ "Malborn (Bat)"
    
[base_unit]
        
id=True Vampire Bat
    
[/base_unit]

    
hitpoints=32    
experience=37
    
hide_help=true

    
[abilities]
        
{ABILITY_VAMPIRE_TRANSFORMATION}
    
[/abilities]

    
{VAMPIRE_INFO_VARIATION ("Malborn") units/vampires/malborn.png}

[female]
        
name= _ "female^Malborn (Bat)"
    
[/female]


{VAMPIRE_INFO_FEM_VARIATION units/vampires/malborn+female.png}
[/unit_type]

the ability's event itself

Spoiler:

Code: Select all

#define VAMPIRE_TRANSFORMATION_EVENT
    
[event]
        
name=start
        
[set_menu_item]
            
id=vampire_transformation
            
description= _ "Transform This Unit"
            
[show_if]
                
[have_unit]
                    
ability=transformation
                    
x,y=$x1,$y1
                    
side=$side_number
                
[/have_unit]
            
[/show_if]
            
[command]
                
[store_unit]
                    
[filter]
                        
x,y=$x1,$y1
                    
[/filter]
                    
variable=to_transform
                    
kill=no
                
[/store_unit]
                
[fire_event]
                    
name=vampire_transform
                
[/fire_event]
            
[/command]
        
[/set_menu_item]
    
[/event]
    
[event]
        
name=vampire_transform
        
first_time_only=no
        
[if]
            
[not]
                
[variable]
                    
name=to_transform.type
                    
contains="Bat"
                
[/variable]
            
[/not]

            
[then]
                
{VAMPIRE_TRANSFORMATION $to_transform.id ("$to_transform.type Bat")}

                
[unit_overlay]
                    
id=$to_transform.id
                    
image={VAMPIRE_OVERLAY $to_transform.image $to_transform.side}
                
[/unit_overlay]

                
[modify_unit]
                    
[filter]
                        
id=$to_transform.id
                    
[/filter]

                    
[variables]
                        
#transformation_previous_type=$to_transform.type
                        
transformation_overlay={VAMPIRE_OVERLAY $to_transform.image $to_transform.side}
                        
transformed=yes
                    
[/variables]
                
[/modify_unit]

                
[clear_variable]
                    
name=to_transform
                
[/clear_variable]
            
[/then]
            
[else]
                
# We don't need the magickal hack number of doom here

                
[remove_unit_overlay]
                    
id=$to_transform.id
                    
image="$to_transform.variables.transformation_overlay"
                
[/remove_unit_overlay]

                
{VAMPIRE_TRANSFORMATION $to_transform.id $to_transform.variation[0].usage}
                
[modify_unit]
                    
[filter]
                        
id=$to_transform.id
                    
[/filter]

                    
[variables]
                        
transformed=no
                    
[/variables]
                
[/modify_unit]

                
# Make sure that moves<=max_moves

                
[store_unit]
                    
[filter]
                        
id=$to_transform.id
                    
[/filter]
                    
variable=tmp_vampire_movement
                   
kill=no
                
[/store_unit]

                
[if]
                    
[variable]
                        
name=tmp_vampire_movement.moves
                        
greater_than=$tmp_vampire_movement.max_moves
                    
[/variable]

                    
[then]
                        
[modify_unit]
                            
[filter]
                                
id=$tmp_vampire_movement.id
                            
[/filter]

                            
moves=$tmp_vampire_movement.max_moves
                        
[/modify_unit]
                    
[/then]
                
[/if]

                
[clear_variable]
                    
name=tmp_vampire_movement
                
[/clear_variable]

                
[clear_variable]
                    
name=to_transform
                
[/clear_variable]
            
[/else]
        
[/if]
    
[/event]
    
[event]
        
name=post advance
        
first_time_only=no
        
[filter]
            
[filter_wml]
                
[variables]
                    
transformed=yes
                
[/variables]
            
[/filter_wml]
        
[/filter]
        
[store_unit]
            
[filter]
                
id=$unit.id
            
[/filter]
            
variable=advanced_vampire
            
kill=no
        
[/store_unit]

        
[remove_unit_overlay]
            
id=$advanced_vampire.id
            
image="$advanced_vampire.variables.transformation_overlay"
        
[/remove_unit_overlay]

        
# HACK: yeah, a hack. Are you really surprised?
        
[if]
            
[variable]
                
name=advanced_vampire.gender
                
equals=female
            
[/variable]

            
[then]
                
[set_variable]
                    
name=transformation_magick_hack_number_of_doom
                    
value=1
                
[/set_variable]
            
[/then]

            
[else]
                
[set_variable]
                    
name=transformation_magick_hack_number_of_doom
                    
value=0
                
[/set_variable]
            
[/else]
        
[/if]

        
[unit_overlay]
            
id=$advanced_vampire.id
            
image={VAMPIRE_OVERLAY $advanced_vampire.variation[$transformation_magick_hack_number_of_doom].image $advanced_vampire.side}
        
[/unit_overlay]

        
[modify_unit]
            
[filter]
                
id=$advanced_vampire.id
            
[/filter]

            
[variables]
                
#transformation_previous_type=$advanced_vampire.variation[0].image
                
transformation_overlay={VAMPIRE_OVERLAY $advanced_vampire.variation[$transformation_magick_hack_number_of_doom].image $advanced_vampire.side}
            
[/variables]
        
[/modify_unit]

        
[clear_variable]
            
name=advanced_vampire
        
[/clear_variable]

        
[clear_variable]
            
name=transformation_magick_hack_number_of_doom
        
[/clear_variable]
    
[/event]

#enddef


# wmllint: unbalanced-on

#define ABILITY_VAMPIRE_TRANSFORMATION
    
[dummy]
        
id=transformation
        
name= _ "transformation"
        
description="Transformation: This unit can transform into a bat. This bat will have the unit's current HP and XP."
    
[/dummy]

#enddef

and

Code: Select all

#textdomain wesnoth-mental-rework
[unit_type]
    
id=Malborn Bat
    
name= _ "Malborn (Bat)"
    
[base_unit]
        
id=True Vampire Bat
    
[/base_unit]

    
hitpoints=32    
experience=37
    
hide_help=true

    
[abilities]
        
{ABILITY_VAMPIRE_TRANSFORMATION}
    
[/abilities]

    
{VAMPIRE_INFO_VARIATION ("Malborn") units/vampires/malborn.png}

[female]
        
name= _ "female^Malborn (Bat)"
    
[/female]


{VAMPIRE_INFO_FEM_VARIATION units/vampires/malborn+female.png}
[/unit_type]

graphical parts:

Spoiler:

Code: Select all

#define BAT_TRANSFORM_FRAME IMAGE_NAME BLEND_COLOR BLEND_RATIO MODIFIER
    
[frame]
        
duration=100
        
image=units/undead/{IMAGE_NAME}.png
        
blend_color={BLEND_COLOR}
        
blend_ratio={BLEND_RATIO}
        
{MODIFIER}
    
[/frame]

#enddef


#define VAMPIRE_TRANSFORM_FRAME IMAGE_NAME BLEND_COLOR BLEND_RATIO MODIFIER
    
[frame]
        
duration=100
        
image=units/vampires/{IMAGE_NAME}.png
        
blend_color={BLEND_COLOR}
        
blend_ratio={BLEND_RATIO}
        
{MODIFIER}
    
[/frame]

#enddef


#define VAMPIRE_TRANSFORMATION _ID _TRANSFORMTO
    
[animate_unit]
        
flag=transform
        
[filter]
            
id={_ID}
        
[/filter]
    
[/animate_unit]
    
[transform_unit]
        
id={_ID}
        
transform_to={_TRANSFORMTO}
    
[/transform_unit]
    
[animate_unit]
        
flag=trans_finish
        
[filter]
            
id={_ID}
        
[/filter]
    
[/animate_unit]

#enddef

#define VAMPIRE_INFO_VARIATION BASIC_TYPE IMAGE
    
[variation]
        
variation_name=info
        
usage={BASIC_TYPE}
        
image={IMAGE}
        
hide_help=true
    
[/variation]

#enddef


# Yeah, no überprocedures for you!

# Don't like it? Too bad!

# NOTE: this is to be the second variation, if used

#define VAMPIRE_INFO_FEM_VARIATION IMAGE
    
[variation]
        
variation_name=info_female
        
image="{IMAGE}"
        
hide_help=true
    
[/variation]

#enddef


#define VAMPIRE_OVERLAY IMAGE SIDE_NUMBER
misc/blank-72x72.png~BLIT("{IMAGE}~TC({SIDE_NUMBER},magenta)~SCALE(38,38)~FL()",34,0)#enddef