[solved]commandline_options.cpp

[Kanapka]

I had some problems with compiling Wesnoth from svn.

I dowloaded r49832 from SVN and tried to compile it with scons. I got the following message:

Code: Select all

scons: Building targets ...
g++ -o build/release/game.o -c -std=c++98 -pthread -W -Wall -O2 -D_GNU_SOURCE=1 -D_REENTRANT -DHAVE_LIBDBUS -DHAVE_CONFIG_H -D_X11 -DDISABLE_POOL_ALLOC -I/usr/include -I/usr/include/SDL -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/fribidi -I. -Isrc -Isrc/ana/api src/game.cpp
g++ -o build/release/commandline_options.o -c -std=c++98 -pthread -W -Wall -O2 -D_GNU_SOURCE=1 -D_REENTRANT -DHAVE_LIBDBUS -DHAVE_CONFIG_H -D_X11 -I/usr/include -I/usr/include/SDL -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/fribidi -I. -Isrc -Isrc/ana/api src/commandline_options.cpp
src/commandline_options.cpp: In function ‘void validate(boost::any&, const std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&, two_strings*, int)’:
src/commandline_options.cpp:32: error: ‘invalid_option_value’ is not a member of ‘boost::program_options::validation_error’
scons: *** [build/release/commandline_options.o] Error 1
scons: building terminated because of errors.

I'd be grateful for some information or pointers if it may be caused by my OS or version of Boost.

I also tried some changes to the code:

Spoiler:

I found line 32 in the commandline_options.cpp and noticed that it said :

Code: Select all

throw new po::validation_error(po::validation_error::invalid_option_value);

where po was an alias for boost::program_options.

I checked the Boost documentation for 1.40.0 and from what I saw in file errors.cpp [link] invalid_option_value inherits after validation_error rather than being a member of it - though I may be wrong.
It appears to be the same in Boost 1.35.

I changed that line to throw an integer instead of invalid_option_value and Wesnoth compiled and ran ok (I ran it until the main menu, then I exited the program). I also tried changing the line to:

Code: Select all

throw new/po::validation_error(po:::invalid_option_value);

and the compiler told me that there was a primary expression before ')' . After that I noticed that the invalid_option_value class had no default constructor (the std::exception class that invalid_option_value inherits from has one, but I don't know if that matters), but it has a constructor that takes a std::string argument. I tried creating a new string and passing it to the constructor (hopefully that's what happened while executing this code):

Code: Select all

                std::string s = "error";
		throw new po::validation_error(po::invalid_option_value(s));

And again, it compiled ok.

System Monitor says my OS is Ubuntu 10.4 (lucid) with Kernel Linux 2.6.32-31-generic
I downloaded the package libboost-all-dev version 1.40.0.1 today (i believe that's where the boost::program_options namespace is, but that's just a wild guess - I found no such namespace in headers included into commandline_options.cpp).

[Zaroth]

That is because of incompatibility between newer Boost.Program_options versions. The compatibility broke somewhere between 1.40 and 1.42. To make sure it's working, please get boost >=1.42 or wait until a relevant #ifdef is added to the file (AFAIK it's just one line in Wesnoth that's incompatible)

Edit: fix for boost versions <1.42 commited, try compiling latest SVN now.

[Kanapka]

I downloaded boost 1.46 and the new version of svn works. Thanks for your help.